Conversation
princerb
left a comment
princerb
left a comment
There was a problem hiding this comment.
Most layout settings are not corresponding to the design of Bootstrap5.
There was a problem hiding this comment.
Boolean field is not improved with form-control or with the components of Bootstrap5.
There was a problem hiding this comment.
And also margins/paddings are not well structured.
There was a problem hiding this comment.
Flash message bug: alerts are not implemented with Bootstrap5
There was a problem hiding this comment.
And also alert close button won't work.
There was a problem hiding this comment.
Navbar toggler bug: doesn't collapse or work.
There was a problem hiding this comment.
When clicking the editable column, it does nothing.
|
This PR pulls in a significant number of new files/amount of new code. Can you help me understand what is copy/paste and what is custom? Can you provide a script that pulls in the copy/paste-able static assets so that it's easier to validate what is provided as-is, and what is custom? This should help identify which areas to review more closely, and which are provided by bootstrap5 (and should theoretically have been critiqued already). |
|
|
Did anyone else try to use this change (Bs5) ? |
|
Could you add an example in the |
|
+1 |
+1 |
|
8 participants
I wanted bootstrap 5 in my application, but flask-admin did not support it.
I have added bootstrap 5 support.
Use
template_mode='bootstrap5'when callingAdmin()app = Flask(__name__) app.config.from_object(Config) db.init_app(app) admin = Admin(app, name='Admin Interface', template_mode='bootstrap5')