add storage parameter to S3FileAdmin#2742
Open
samialfattani wants to merge 1 commit intopallets-eco:masterfrom
Open
add storage parameter to S3FileAdmin#2742samialfattani wants to merge 1 commit intopallets-eco:masterfrom
samialfattani wants to merge 1 commit intopallets-eco:masterfrom
Conversation
Contributor
|
What is the advantage? |
Contributor
Author
One of the uses cases that if the user wants to add the Prefix functionality, then he needs to change the behavior of some functions in S3Storage class. so this PR enables him to do so by subclassing of S3Storage and override the functions that need to bo changed to support Prefix functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables users to inherit the
S3Storageand inject it inS3FileAdmin