Skip to content

fix(x/skyway): use the correct errEthereumSender instead of `errRec… #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

tinyfoxy
Copy link
Contributor

@tinyfoxy tinyfoxy commented Apr 1, 2025

…eriverAddr`

Related Github tickets

N/A

Background

errTokenAddress has been checked before, it should be nil after that

        if errTokenAddress != nil {
		logger.WithError(errTokenAddress).Error("Invalid token contract")
		return sdkerrors.Wrap(errTokenAddress, "invalid token contract on claim")
	}

	// likewise nil sender would have to be caused by a bogus event
	if errEthereumSender != nil {
		logger.WithError(errEthereumSender).Error("Invalid ethereum sender")
		return sdkerrors.Wrap(errTokenAddress, "invalid ethereum sender on claim")
	}

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@taariq taariq requested a review from byte-bandit April 1, 2025 01:53
@byte-bandit byte-bandit merged commit 14421a8 into palomachain:master Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants