GH1222 Candidate for ty on pandas-stubs #1240
Merged
+142
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
commented
Jun 5, 2025
Dr-Irv
requested changes
Jun 5, 2025
Co-authored-by: Irv Lustig <[email protected]>
|
Agreed with adding it to the CI, for how it would only be for pandas-stubs and not the tests as the project is still experimental there is a lot to do and understand on the tests side. Worst case if we see it as a blocker on velocity we can bring it to merge only. Let me do the changes |
|
Right now this would run with |
Dr-Irv
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Thanks @loicdiridollou you'll have to keep an eye on version improvements on ty so that pyproject.toml gets properly updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valueProposal to have ty on pandas-stubs, on tests there are still a lot of errors that come back as TODO from ty and the inference is a bit unclear for many tests (or it comes back as Unknown so would need more investigation and learning on my end).