TST: xStringArray and NumpyExtensionArray
#1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
commented
Dec 25, 2025
cmp0xff
commented
Dec 25, 2025
pandas-stubs/core/arrays/base.pyi
Outdated
Comment on lines
128
to
130
| def value_counts( | ||
| self, dropna: bool = True | ||
| ) -> Series[int]: ... # probably to put in base class |
Contributor
Author
There was a problem hiding this comment.
In NDArrayBackedExtensionArray instead of here.
Member
There was a problem hiding this comment.
Are we sure about this, seems like ExtensionArray does not inherit from any other class so wondering how the signature would percolate?
Contributor
Author
There was a problem hiding this comment.
My stand is that either we keep the original inheritance, or we can omit some classes if there is no public API. value_counts is public, and lives in NDArrayBackedExtensionArray, so we should keep it there.
loicdiridollou
requested changes
Dec 26, 2025
Member
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Minor questions, will do a second pass tomorrow since it is a rather long PR.
Contributor
Author
|
Indeed it is too big, will create a few smaller PRs before the main one |
This was referenced Dec 26, 2025
cmp0xff
force-pushed
the
feature/numpy-extension-array
branch
2 times, most recently
from
9d39019 to
5af2d1f
Compare
cmp0xff
force-pushed
the
feature/numpy-extension-array
branch
from
5af2d1f to
976490a
Compare
…e/numpy-extension-array
…e/numpy-extension-array
cmp0xff
changed the title
PandasArray -> NumpyExtensionArrayxStringArray and NumpyExtensionArray
cmp0xff
commented
Dec 31, 2025
Dr-Irv
requested changes
Dec 31, 2025
Dr-Irv
approved these changes
Jan 2, 2026
loicdiridollou
pushed a commit
that referenced
this pull request
Jan 5, 2026
* fix: nightly * confirm pandas-dev/pandas#63567 * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1589, #1469, #1580
A
NumpyExtensionArrayis produced