Skip to content

BUG: Fix clip failing with scalar numpy array (GH-59053) #63807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amey-sd wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

BUG: Fix clip failing with scalar numpy array (GH-59053) #63807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6861,7 +6861,7 @@ def _flex_method(self, other, op, *, level=None, fill_value=None, axis: Axis = 0

if isinstance(other, Series):
return self._binop(other, op, level=level, fill_value=fill_value)
elif isinstance(other, (np.ndarray, list, tuple, ExtensionArray)):
elif isinstance(other, (list, tuple)) or (isinstance(other, np.ndarray) and other.ndim > 0):
if len(other) != len(self):
raise ValueError("Lengths must be equal")
other = self._constructor(other, self.index, copy=False)
Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/series/methods/test_clip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,11 @@ def test_clip_with_timestamps_and_oob_datetimes_non_nano(self):
expected = Series([lower, upper], dtype=dtype)

tm.assert_series_equal(result, expected)

def test_clip_with_scalar_array_lower(self):
# GH#59053
ser = Series([-1, 2, 3])
lower = np.array(0)
result = ser.clip(lower=lower)
expected = Series([0, 2, 3])
tm.assert_series_equal(result, expected)
Loading