Skip to content

fix: missing value after comparison #63831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sharl0tteIsTaken wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix: missing value after comparison #63831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/core/ops/array_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def comp_method_OBJECT_ARRAY(op, x, y):
result = libops.vec_compare(x.ravel(), y.ravel(), op)
else:
result = libops.scalar_compare(x.ravel(), y, op)
result = np.where(isna(x), x, result)
Copy link
Member

@rhshadrach rhshadrach Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct behavior; e.g. 5 = = np.nan should give False. We only want to change the behavior for pd.NA.

Copy link
Author

@Sharl0tteIsTaken Sharl0tteIsTaken Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make sure, only replace pd.NA is the intended behavior? so not to replace any of None, pd.NaT, np.nan?

If so, pd.isna() and np.isnan() both aren't gonna work. It seems only the Python is operator is capable to differentiate pd.NA with others. If there's another way to do this, please let me know. Much appreciated!

return result.reshape(x.shape)


Expand Down
Loading