Skip to content

CLN: Delete decorator Appender #63846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhengruifeng wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLN: Delete decorator Appender #63846

zhengruifeng wants to merge 2 commits into from
+1 −46

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Jan 24, 2026

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

@mroeschke
Copy link
Member

mroeschke commented Jan 24, 2026

Looks like statsmodels uses Appender (and Substitution) though these are private API. I suppose instead we need to deprecate these objects first

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Jan 25, 2026

@mroeschke got it, will try to deprecate it! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhengruifeng @mroeschke