TST: Add regression test for GH#55969 datetime.date MultiIndex with np.datetime64#64296
Open
ManasVardhan wants to merge 2 commits intopandas-dev:mainfrom
Open
TST: Add regression test for GH#55969 datetime.date MultiIndex with np.datetime64#64296ManasVardhan wants to merge 2 commits intopandas-dev:mainfrom
ManasVardhan wants to merge 2 commits intopandas-dev:mainfrom
Conversation
The underlying bug GH#55969 is not yet fixed. Mark the regression test as xfail so CI passes while the test documents the expected behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for #55969.
The bug was that accessing a MultiIndex with
datetime.dateat level 0 usingnp.datetime64would ignore the second level filter and return all rows matching the date.The bug has already been fixed on main. This PR adds a test to prevent regression:
df.loc[(np.datetime64_date, 'A')]correctly returns only rows matching both levelsdf.loc[(np.datetime64_date, 'B')]correctly returns only rows matching both levelsdf.loc[(np.datetime64_date, 'C')]raisesKeyErrorwhen the combination does not exist