Skip to content

propagate aborted flag from Match to ClientMatch #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

propagate aborted flag from Match to ClientMatch #708

wants to merge 2 commits into from

Conversation

JamesVanBoxtel
Copy link
Contributor

Fixes #607

@Endaris
Copy link
Collaborator

Endaris commented Oct 13, 2025

Rather than duplicating state, could we just mask it with a getter so we only handle state in one place?

@JamesVanBoxtel
Copy link
Contributor Author

Rather than duplicating state, could we just mask it with a getter so we only handle state in one place?

Yeah I'm pretty sure we can.

@JamesVanBoxtel
Move aborted to only Match
2870ff2 
Also documented some match params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Client does not properly communicate an abort due to desync

2 participants

@JamesVanBoxtel @Endaris