Merge pull request #462 from nsmlzl/fix_segfault_layout

AndreaGuarracino · web-flow · commit 8715c555c9fd · 2022-11-28T09:45:53.000-06:00
Fix segfault when no progress flag set
diff --git a/src/algorithms/path_sgd_layout.cpp b/src/algorithms/path_sgd_layout.cpp
@@ -374,7 +374,9 @@ namespace odgi {
                                     term_updates_local++;
                                     if (term_updates_local >= 1000) {
                                         term_updates += term_updates_local;
-                                        progress_meter->increment(term_updates_local);
+                                        if (progress) {
+                                            progress_meter->increment(term_updates_local);
+                                        }
                                         term_updates_local = 0;
                                     }
                                 }

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,9 @@ namespace odgi {`
`374`	`374`	`term_updates_local++;`
`375`	`375`	`if (term_updates_local >= 1000) {`
`376`	`376`	`term_updates += term_updates_local;`
`377`		`- progress_meter->increment(term_updates_local);`
	`377`	`+ if (progress) {`
	`378`	`+ progress_meter->increment(term_updates_local);`
	`379`	`+ }`
`378`	`380`	`term_updates_local = 0;`
`379`	`381`	`}`
`380`	`382`	`}`