Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grouping api #51

Merged
merged 3 commits into from
Nov 5, 2020
Merged

grouping api #51

merged 3 commits into from
Nov 5, 2020

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Nov 2, 2020

This a first attempt at the grouping api I discussed in #49. It introduces a new Grouper object that supports iteration by group. I've written up a padded day-of-year grouper as a demo.

cc @dgergel, @jukent

closes #49

@dgergel
Copy link
Contributor

dgergel commented Nov 3, 2020

See the padded day-of-year grouper that already exists with the same name in #28. There is good functionality in the one you have here, but it should be built off of what's already in #28 given that that was already under development, this borrows logic from that one, and that PR was already ready to be merged.

@jhamman
Copy link
Member Author

jhamman commented Nov 3, 2020

@dgergel - yes, absolutely. The individual groupers are not the interesting part of this PR. The GroupedRegressor is the bit we should all take a look at to evaluate if it could work for our existing (e.g. BCSD/Zscore) or future implementations.

@jhamman jhamman marked this pull request as ready for review November 5, 2020 16:54
@jhamman
Copy link
Member Author

jhamman commented Nov 5, 2020

Merging as is so we can start playing with the new api. @dgergel, I've kept the separate namespaces for groupers and grouping for now. Eventually, those will probably be merged but for now, this gives us the option to proceed incrementally.

@jhamman jhamman closed this Nov 5, 2020
@jhamman jhamman reopened this Nov 5, 2020
@jhamman jhamman merged commit 5ba01e3 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level API for time grouping
2 participants