Add pole_kind to grids #236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huard
commented
Feb 3, 2023
huard
commented
- Add docstring. Handle ESMF versions prior to 8.0.1 that do not support pole_kind option.
Add docstring. Handle ESMF versions prior to 8.0.1 that do not support pole_kind option.
Closed
Contributor
|
we should use #228 to generate a synthetic tripolar grid for the testing. I have a PR that fixes a minor testing issue that needs to go through first then we should get this one in. |
Contributor
Author
|
Salut @raphaeldussin Is this something that can reasonably done over summer ? |
Contributor
|
Salut @huard The code basically works, I've been working on a test with synthetic data from tripolar to regular lat/lon but I can't get it to generate different solutions with and without the option. I suspect the test is too simple... I'm going to work on this very soon because I really want this option to be available as it greatly improves remapped solution in the Arctic. |
Contributor
|
re-implemented in #415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.