-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate bakery implementation-specifics to bakeries #175
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Apologies for the chatter/failing CI, my pytest locally is using obviously cached files and though I've burned pyc and pycache, it persists in running old code 😭 EDIT: Just to be clear, this was hopeless stupidity on my part. Forgot the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 95.53% 94.80% -0.73%
==========================================
Files 14 15 +1
Lines 493 520 +27
==========================================
+ Hits 471 493 +22
- Misses 22 27 +5 ☔ View full report in Codecov by Sentry. |
91bc316
to
96d9afa
Compare
Traitlets is a cruel master. Where in the hell are the post_init hooks? How could they build a validation library without them!? |
This PR aims to clean up
Bake.py
as it is central to the library's functionality. To this end,Bakery
implementation specifics are handled by the bakeries themselves. There are two central components to this change:bakery.bake
is now used to delegate the specifics of running a pipeline to the bakeries themselves