SCSZ-1622 added auto merge support #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrorama
commented
Nov 29, 2023
.github/workflows/dependabot-prs.yml
Outdated
| github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
| - name: Approve and merge Dependabot PRs for development dependencies | ||
| # Auto-merge the PR if either: | ||
| # a) it has the `development-dependencies` label, which we add for certain |
Contributor
Author
There was a problem hiding this comment.
This dependabot setup differs from the norm. It is missing the steps:
- Get unique committers
- Disable auto-merge if there are commits from someone other than Dependabot
- Add the Needs QA label to dependabots after any change by someone other than the dependabot bot
I believe I set it up like this a while back by guidance from @JacobEvelyn . IIRC, I think we omitted these because it wasn't needed. Additionally, we don't use buildkite here since the code is small enough to rely on github actions.
There was a problem hiding this comment.
@cyrorama if we're assigning these out it seems a little strange to me that we wouldn't disable auto-merging if someone had committed on a PR here. I'm not clear on what we gain from not doing those steps really. Any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependabot settings to add auto merge support.
See this for more info: https://docs.google.com/document/d/1IsbASOo7kSbDrFGYvdOjyUfzZhbprcnh8qtehE4U1ew/edit