Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pants package :pex doesn't remove source root prefix for generated resources #21438

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

grihabor
Copy link
Contributor

@grihabor grihabor commented Sep 19, 2024

Closes #21444

TODO the actual fix for the problem

See the test for the full example.

@tdyas tdyas added the category:bugfix Bug fixes for released features label Sep 20, 2024
@grihabor
Copy link
Contributor Author

Created a separate issue #21444

@huonw huonw marked this pull request as draft November 2, 2024 09:51
@huonw
Copy link
Contributor

huonw commented Nov 2, 2024

I'm inferring from the Debugging... commit and the seemingly-relevant test failures that this is not yet ready for review. I've marked it as draft to avoid someone accidentally reviewing.

If my inference is incorrect, please let me know/un-draft it.

(As always, thank you for contributing!)

@grihabor
Copy link
Contributor Author

grihabor commented Nov 2, 2024

All correct, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated resources have wrong path in a pex_binary
3 participants