merge instread of overwrite args for scie pex #23020
Open
+65
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburroughs
added
the
release-notes:not-required
sureshjoshi
reviewed
Jan 15, 2026
| entry_point="main.py", | ||
| dependencies=[":sources", "lib:dist"], | ||
| scie="eager", # Going to run it, so might as well | ||
| scie_pbs_release="20251031", |
Member
There was a problem hiding this comment.
Will this test run, and thus download this PBS each time?
Contributor
Author
There was a problem hiding this comment.
I'm unsure how the caching works in RuleRunner/integration-test land. We could keep it lazy and rely on Pex erroring instead of the end-to-end stdout assertion if you are concerned.
Member
There was a problem hiding this comment.
Not concerned yet. Just trying to keep a mental audit of stuff we do that can/will drag test out time - and whether we can cache in CI to help that out.
So, just a bit of an identification process right now - wasn't sure if you'd run this and seen the result yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation merged
additional_argsfrompackage_pex_binaryand the scie args, but inadvertently dropped anyadditional_argsadded bycreate_pex_from_targetsitself. Notablycreate_pex_from_targetsdoes so forlocal_dists.create_pex_from_targetsneeds to go "first" do the merge between all threeadditional_argssources.LLM Disclosure: A LLM both figured out the bug and wrote the fix+test.