Skip to content

Support rails optimistic locking #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yosefbennywidyo
Copy link

@yosefbennywidyo yosefbennywidyo commented Jun 6, 2025

  • Increment lock_version by 1 on the reified object if :lock_version attribute is present.
  • Add a test for reifying an object with an optimistic lock.
  • Update Rails version to 8.0.0.rc1 in Gemfile generated by Appraisal.
  • Add CarWithLockVersion model and corresponding specs
  • Rename Naming/PredicateName to Naming/PredicatePrefix in .rubocop.yml
  • Fix offenses rubocop
  • Update method name to follow predicate naming convention for controller
  • Add entry for Rails optimistic locking support in CHANGELOG
  • Fix method reference for enabling PaperTrail in controller
  • Fix documentation typo in PaperTrail::Request for controller method reference
  • Related to #163

Thank you for your contribution!

Check the following boxes:

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

- Increment lock_version by 1 on the reified object
  if :lock_version attribute is present.
- Add a test for reifying an object with an optimistic lock.
- Update Rails version to 8.0.0.rc1 in gemfile generated by Appraisal.
- Add CarWithLockVersion model and corresponding specs
- Rename Naming/PredicateName to Naming/PredicatePrefix in .rubocop.yml
- Fix offenses rubocop
- Update method name to follow predicate naming convention for controller
- Add entry for Rails optimistic locking support in CHANGELOG
- Fix method reference for enabling PaperTrail in controller
- Fix documentation typo in PaperTrail::Request
  for controller method reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant