fix:unarchive fails for user id != 1000 #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borismw
force-pushed
the
fix/unarchive-fails-for-user-other-than-id-1000
branch
from
80be532 to
4da6829
Compare
borismw
force-pushed
the
fix/unarchive-fails-for-user-other-than-id-1000
branch
from
4da6829 to
2c92b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to issue #239. If the
paperless_ngx_conf_usermap_uidvariable is set to an id different from 1000, the unarchive fails to unpack files and change their ownership. This seems to be because the user unpacking the archive is different from the one owning the files.This PR adds a lookup step to find out the correct user name with
id == 1000in causepaperless_ngx_conf_usermap_uid != 1000. The user name stored in the variable_paperless_ngx_untar_usernamewill then later be used as thebecome_userin the unarchive step.Note that with this solution
paperless_ngx_conf_usermap_uidis not definedthe lookup step will fail even though the user might perchance be created with the id 1000.
In order to prevent this one might to either have to move the system user creation step to an earlier stage or make
paperless_ngx_conf_usermap_uidmandatory. I was not sure if it was okay to go down any of these routes.