perf(db): Reuse cursors in the Latest/HistoricalStateProviders #20519
+222
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediocregopher
added
C-perf
mediocregopher
requested review from
joshieDo,
rakita and
shekhirin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
ReusableCursortype which automatically returns a cursor to a Cell on Drop. By holding a Cell for each table type we are able to reuse cursors in the state providers.I wanted to make this even more generic and automatic, so that we automatically reuse dropped cursors on every Tx, but doing so is a bigger lift. This should at least get us something useful.
Closes #20492