chore(flashblocks): remove dead cached_reads wipe after finalize #20538
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozirDmitriy
requested review from
Rjected,
fgimenez and
mattsse
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlashBlockPendingSequence::finalize already clears cached_reads, and this behavior is enforced by tests. The extra
take_cached_reads call in SequenceManager::insert_flashblock always operated on None and had no effect, while its comment suggested that it was responsible for wiping the cache. Removing this no-op call and misleading comment makes the cache lifecycle clearer and keeps the implementation aligned with the tested invariants.