fix: enable file logging for LogFmt format #20556
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `LogFormat::LogFmt` implementation ignored the provided `file_writer` argument, causing logs to output to stdout even when file logging was configured. This commit adds the logic to attach the non-blocking writer to the logfmt layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
LogFormat::applymethod, the Json andTerminalvariants correctly checked for afile_writer(aNonBlockingwriter) and attached it to the tracing layer. However, theLogFmtvariant was missing this logic, resulting in logs always being printed to stdout, even if the application was configured to write to a log file.The Solution:
I updated the
LogFormat::LogFmtmatch arm to check iffile_writerisSome. If it is, the layer is now configured using.with_writer(writer), ensuring consistency with the other logging formats.