fix: use pre code if hash matches #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue where we would return diffs like
for
0x91b066df39661db7bcca1cb8bb8afd11816414408d44cbfcf6144f440d5dfe3bref paradigmxyz/reth#19703however nothing changed in the account here and these should have been filtered out via:
revm-inspectors/src/tracing/builder/geth.rs
Line 349 in f750352
and cleared from post via:
https://github.com/alloy-rs/alloy/blob/35e20437670d987680a6715bcc173f3d357f8254/crates/rpc-types-trace/src/geth/pre_state.rs#L188-L201
the reason why this didn't work is because:
the code can be None here which would make retain_change not remove the values
we can always use the precode here if the hashes match