feat(TraceWriter): order the storage writes in last-write order #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage writes were written in non determinstic order because of HashMap usage. Instead, to make it more intuitive, the storage slot changes are shown in the order of their last writes.
Author
|
I personally think intermediate storage writes can be useful too when debugging. Perhaps in another level deep of verbosity. |
mattsse
reviewed
Dec 18, 2025
Contributor
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
dont really have an opinion here
defer to @DaniPopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage writes were written in non determinstic order because of HashMap usage. Instead, to make it more intuitive, the storage slot changes are shown in the order of their last writes.