fix: warmed storage values for GethTrace using DebugInspector
#389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Dec 21, 2025
Contributor
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
one question re the removed journal change check
| let reason = match op { | ||
| opcode::SLOAD => StorageChangeReason::SLOAD, | ||
| opcode::SSTORE => StorageChangeReason::SSTORE, | ||
| _ => unreachable!(), |
Contributor
There was a problem hiding this comment.
I'm not sure if this is still unreachable now
Comment on lines
+556
to
564
| Some(JournalEntry::StorageWarmed { key, address }) => { | ||
| // SAFETY: (Address,key) exists if part if StorageChange | ||
| let value = | ||
| context.journal_ref().evm_state()[address].storage[key].present_value(); | ||
| let change = StorageChange { key: *key, value, had_value: None, reason }; | ||
| Some(Box::new(change)) | ||
| } | ||
| _ => None, | ||
| } |
Contributor
There was a problem hiding this comment.
is this effectively the only change that we need here, the missing
JournalEntry::StorageWarmed { key, address }
variant?
Comment on lines
-538
to
-539
| // If journal has not changed, there is no state change to be recorded. | ||
| if self.config.record_state_diff && journal.len() != self.last_journal_len { |
Contributor
There was a problem hiding this comment.
why was this check removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default tracer for
debug_*RPC methods was not reporting warmed storage values. This deviates from Get's implementation and—seemingly—the documented expectation:In particular, the
SLOADfor pc235,279, and308are missing"storage". This PR resolves the issue.For reference:
revm-inspectors.json
geth.json