feat(sema): implicit integer conversions #564
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Oct 7, 2025
| // handles integer literals | ||
| if self.is_integer() | ||
| && other.is_integer() | ||
| && (!self.is_signed() || other.is_signed()) |
Member
There was a problem hiding this comment.
?
Suggested change
| && (!self.is_signed() || other.is_signed()) | |
| && self.is_signed() == other.is_signed() |
Contributor
Author
There was a problem hiding this comment.
no, an unsigned integer can be assigned to a signed integer and thus the implicit conversion works :)
if lhs is signed, you can assign unsigned or signed
if lhs is unsighed, you can only assign unsigned
Member
There was a problem hiding this comment.
there should be a difference between literals which can coerce to either signed or unsigned, and typed integers, which can only upcast
Contributor
Author
There was a problem hiding this comment.
yeah makes sense but unrelated to ts line
Contributor
Author
|
Putting this in draft, I think it would make sense to tackle #560 first as it makes testing all the cases easier |
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles implicit integer resizing (larger → smaller) for
uintNandintN, as well as integer literal conversions. This is plagued by #560 however.