fix(sema): avoid parameter name shadowing during type resolution #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Parameter names were shadowing type names during type resolution, causing incorrect type lookups when a parameter name matched a type name used in later parameters.
This bug is described in this issue: #219, where resolving the second parameter's type StructType, the compiler would incorrectly find the first parameter's name instead of the struct definition.
Solution
Implemented lower_variables_two_phasealternative to lower_variables that uses two phases to first resolve all parameters without declaring any names and then declares all parameters once the types are already resolved.
Added also this case as a test in
tests/ui/resolveTest
Before the changes:
After the changes