feat(sema): implicit bytes literal conversion to bytes dynamic/fixed #642
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
changed the title
Member
|
You can merge main and you'll have an error enum you can add a variant to improve the error message |
DaniPopes
reviewed
Dec 22, 2025
| if size_from.bytes() <= size_to.bytes() { | ||
| Ok(()) | ||
| } else { | ||
| Result::Err(TyConvertError::InvalidConversion) |
Member
There was a problem hiding this comment.
can you add a new variant to match the solc error message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #640
When I run solc on the test case the error message was
Solar was giving
Happy to work on making the error more descriptive on another issue. If so let me know