Skip to content

feat(typeck): contracts/address explicit conversions #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jds-23 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(typeck): contracts/address explicit conversions #646

Jds-23 wants to merge 4 commits into from
+165 −3

Conversation

@Jds-23
Copy link
Contributor

@Jds-23 Jds-23 commented Dec 16, 2025

Closes #643

  • Added errors AddressNotPayable and ContractNotPayable
  • Added conversion match arms in try_convert_explicit_to:
    • contract ↔ address / address payable (with receivability checks)
  • Refactored Payable expression handler to use try_convert_explicit_to
  • Added helper function can_receive_ether() to check contract receivability

@onbjerg onbjerg added C-enhancement Category: an issue proposing an enhancement or a PR with one A-sema Area: semantic analysis labels Dec 16, 2025
DaniPopes
DaniPopes approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

No one assigned

Labels

A-sema Area: semantic analysis C-enhancement Category: an issue proposing an enhancement or a PR with one

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Contracts<->address explicit conversions

3 participants

@Jds-23 @DaniPopes @onbjerg