feat(ast): change TypeSize to store bits instead of bytes #671
+36
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
A-sema
This enables distinguishing edge cases like 127 (fits in int8) from 128 (doesn't fit), which is needed for correct implicit and explicit integer conversions. - Changed internal storage from u8 (bytes 0-32) to u16 (bits 0-256) - TypeSize::new() now takes bits directly - Added new_fb_bytes() for fixed-bytes types that take byte counts - bits() returns stored value, bytes() computes ceil(bits/8) - mk_ty_int_literal no longer rounds to multiples of 8 Closes #650
onbjerg
force-pushed
the
onbjerg/typesize
branch
from
865b24d to
7df76e4
Compare
DaniPopes
reviewed
Dec 22, 2025
| #[inline] | ||
| pub const fn bytes(self) -> u8 { | ||
| if self.0 == 0 { Self::MAX } else { self.0 } | ||
| if self.0 == 0 { 32 } else { self.0.div_ceil(8) as u8 } |
DaniPopes
reviewed
Dec 22, 2025
| #[track_caller] | ||
| pub const fn bytes_keyword(self) -> Symbol { | ||
| kw::fixed_bytes(self.0) | ||
| kw::fixed_bytes(self.bytes()) |
Member
There was a problem hiding this comment.
these should be bytes_raw so that 0 maps to the int uint kw without a bit size
| self.mk_ty(TyKind::StringLiteral( | ||
| std::str::from_utf8(s).is_ok(), | ||
| TypeSize::new(s.len().min(32) as u8).unwrap(), | ||
| TypeSize::new(s.len().min(32) as u16 * 8).unwrap(), |
Member
There was a problem hiding this comment.
we should just rm fn new and use from_bytes from_bits instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables distinguishing edge cases like 127 (fits in int8) from 128 (doesn't fit), which is needed for correct implicit and explicit integer conversions.
u8(bytes 0-32) tou16(bits 0-256)TypeSize::new()now takes bits directlynew_fb_bytes()for fixed-bytes types that take byte countsbits()returns stored value,bytes()computesceil(bits/8)mk_ty_int_literalno longer rounds to multiples of 8Closes #650
Unblocks #647 #648 #649