-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bindings for riscv64gc-unknown-linux-gnu target #212
base: main
Are you sure you want to change the base?
Conversation
I think this looks good. The lint you had to disabled should be accounted for in main so if you could rebase we'd proceed with this one. Sorry for the delay - I guess it's holiday season 😅 |
I'm happy with the patch, but as @wiktor-k says, would be good to rebase and re-enable the lint. Apologies for the long delay 🥲 |
0f0e77d
to
348eedf
Compare
All set. Sorry for the delay, and thank you! |
This change adds riscv64gc-unknown-linux-gnu bindings for cryptoki-sys crate and adds the target to ci.sh and regenerate_bindings.sh for future updates. This change will enable building the package for risvc in Fedora. Signed-off-by: Neil Hanlon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If my suggestion is correct, you only need to rebase and the CI should pass 🙏
@@ -75,6 +75,16 @@ include!(concat!( | |||
"/src/bindings/loongarch64-unknown-linux-gnu.rs" | |||
)); | |||
|
|||
#[cfg(all( | |||
not(feature = "generate-bindings"), | |||
target_arch = "riscv64gc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target_arch = "riscv64gc", | |
target_arch = "riscv64", |
This change adds riscv64gc-unknown-linux-gnu bindings for cryptoki-sys
crate and adds the target to ci.sh and regenerate_bindings.sh for future
updates. This change will enable building the package for risvc in
Fedora.
n.b., in order to build locally I disabled the
unused_qualifications
lint due to the following:If this change is not preferred or required, I can drop the hunk from the PR.