Add capability to load symbols from current executable

[EliseChouleur]

If PKCS#11 symbols are available inside the current executable as it can be necessary for iOS development.

[hug-dev]

Thanks for the PR!

I am curious, in which context would the library be contained in the executable? In case it has been statically linked 🤔?

Also wondering if instead of changing the interface and introducing the new LibLoadingType we could create a new constructor, like new_from_self which would do the same :) What do you think?

[wiktor-k]

I agree with @hug-dev that this can be simplified. Btw, I'm on mobile, isn't the libloading dep missing from cargo.toml?

The idea behind the change is good though!

[EliseChouleur]

Thanks for the PR!

I am curious, in which context would the library be contained in the executable? In case it has been statically linked 🤔?

Also wondering if instead of changing the interface and introducing the new LibLoadingType we could create a new constructor, like new_from_self which would do the same :) What do you think?

Yes when it's statically linked, which is mandatory on iOS when following the AppStore rules :)
I was hesitating between different approch when searching on how to add this feature and the duplication of the new function was one of them, so I've changed it to that.

[EliseChouleur]

I agree with @hug-dev that this can be simplified. Btw, I'm on mobile, isn't the libloading dep missing from cargo.toml?

The idea behind the change is good though!

We were already using this on iOS and Android with the old rust-pkcs11 crate (but never merged on upstream), so it's working well. And I've tested it on a real device ;)

[wiktor-k]

This is shaping really nicely 👌

I won't be able to look at it deeply before Monday, though :(

[wiktor-k]

LGTM 👍 thanks!

[EliseChouleur]

Could you tell me what's happening next ? Or more precisely, what could be the ETA of an official release with this version ? :)
Thanks a lot !

[hug-dev]

what could be the ETA of an official release with this version

We have no schedule set! It's all based on demand. Since the last release was in June and we got quite a lot of contributions recently, I guess we could make a new version if you wanted!

[wiktor-k]

I guess we could make a new version if you wanted!

I think it's a good idea. As you've said we have quite a lot of good contributions piled-up in main that people may wait for 👍

[hug-dev]

We can maybe announce in the community channel that a new release will be done in like two weeks, so that people have time to push in more changes before the release?

[wiktor-k]

We can maybe announce in the community channel that a new release will be done in like two weeks, so that people have time to push in more changes before the release?

Yes, excellent idea! :)