feat: add support for vendor defined key types #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mete Can Eriş <[email protected]>
|
Do you have any other improvements (which are more than welcome 🥇 ) on the way? I was otherwise thinking of cutting a new version of the crate! |
I'm trying to test Thales' extensions for Bip32 and Slip10, but I think with this PR, it will be possible. Wouldn't want to delay the release. |
wiktor-k
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds supports for vendor defined key types. The implementation replicates new_vendor_defined method for defining vendor defined key types.
Support for vendor defined mechanisms (#232) and vendor defined attributes (#237) has already been implemented. However, there is no way to define a new
KeyTypeas the innervalfield is private, and existingKeyTypevariants are defined as constants. Supporting vendor defined extensions such as Thales' BIP32 requires passing of a vendor defined key type (such asCKK_BIP32) in the private/public key templates asAttribute::KeyType.