Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: liquidate erc721 with credit #307

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Dec 29, 2022

Signed-off-by: GopherJ [email protected]

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@GopherJ GopherJ requested a review from a team as a code owner December 29, 2022 08:02
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #307 (a996a45) into main (fcb705c) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head a996a45 differs from pull request most recent head 09a83d9. Consider uploading reports for the commit 09a83d9 to get more accurate results

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   75.24%   74.98%   -0.27%     
==========================================
  Files          83       82       -1     
  Lines        3826     3722     -104     
  Branches      714      698      -16     
==========================================
- Hits         2879     2791      -88     
+ Misses        571      566       -5     
+ Partials      376      365      -11     
Impacted Files Coverage Δ
contracts/protocol/pool/PoolCore.sol 76.27% <ø> (ø)
...acts/protocol/libraries/logic/LiquidationLogic.sol 97.93% <100.00%> (+0.91%) ⬆️
...racts/protocol/libraries/logic/ValidationLogic.sol 61.68% <100.00%> (-1.53%) ⬇️
...ntracts/misc/flashclaim/UserFlashclaimRegistry.sol 80.00% <0.00%> (-5.72%) ⬇️
...acts/misc/flashclaim/AirdropFlashClaimReceiver.sol 45.09% <0.00%> (-2.18%) ⬇️
contracts/protocol/tokenization/PToken.sol 87.71% <0.00%> (-1.76%) ⬇️
...acts/protocol/libraries/logic/MarketplaceLogic.sol 90.51% <0.00%> (-1.32%) ⬇️
...rotocol/tokenization/libraries/ApeStakingLogic.sol 90.00% <0.00%> (-0.91%) ⬇️
...ntracts/protocol/tokenization/NTokenApeStaking.sol 74.07% <0.00%> (-0.12%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant