Wire up oomprof #3078
Merged
Wire up oomprof #3078
+751
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnurizen
force-pushed
the
oomprof
branch
3 times, most recently
from
bb5d58a to
2df36be
Compare
brancz
reviewed
Jul 31, 2025
reporter/parca_reporter.go
Outdated
| // for memory profiles. | ||
| // TODO: does this matter? Should we have a batch API for memory profiles that | ||
| // sends its own sample record optimized for memory profiles? Probably... | ||
| //w.Producer.ree.Append(rows) |
There was a problem hiding this comment.
can we delete these? perf wise it's probably fine to do for every sample since most times the ree count is just continued
umanwizard
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.