Skip to content

Upgrade wallet connect #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2023
Merged

Upgrade wallet connect #135

merged 2 commits into from
Aug 11, 2023

Conversation

VadimSaveljev
Copy link
Contributor

@VadimSaveljev VadimSaveljev commented Aug 7, 2023 •
edited
Loading

  • Moved away from a deprecated lib @walletconnect/qrcode-modal to @walletconnect/modal
  • Added session handling - no need to scan QR code everytime now, also if session is deleted from the wallet side it now can be handled (onSessionDelete prop) and dapp developer can update the state accordingly.
  • Closing modal won't create a crash
  • Added optional chain ids support
  • Updated libs to latest versions

@VadimSaveljev VadimSaveljev requested a review from hamidra August 7, 2023 12:31
hamidra
hamidra reviewed Aug 10, 2023
View reviewed changes
hamidra
hamidra suggested changes Aug 10, 2023
View reviewed changes
hamidra
hamidra reviewed Aug 11, 2023
View reviewed changes
@VadimSaveljev VadimSaveljev merged commit 80ac694 into main Aug 11, 2023
@VadimSaveljev VadimSaveljev deleted the wallet-connect-upgrade branch August 11, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamidra hamidra hamidra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VadimSaveljev @hamidra