-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[DRAFT] statement-store: re-defining RPC API surface #10452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…e_dev --bump major'
Co-authored-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
3fac3cc to
b3d1b36
Compare
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
| item = Bytes, | ||
| with_extensions, | ||
| )] | ||
| fn subscribe_statement( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm the logic, am i right that this endpoint immediately provide currently matching statements and then send new matching statement once they appear in the store? Also if the current number of statements is too big will it automatically split them into pages the return in the separate updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm the logic, am i right that this endpoint immediately provide currently matching statements and then send new matching statement once they appear in the store?
Yes, the plan is to immediately provide currently matching statements.
Also if the current number of statements is too big will it automatically split them into pages the return in the separate updates.
Not sure I understand why would you need pagination for the subscribe, you would receive each statement one by one.
Signed-off-by: Alexandru Gheorghe <[email protected]>
8bc0975 to
acf0103
Compare
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Taking a stab at making the API surface easier to understand and complete for the required use cases.
Proposal
priorityin expiry, make it mandatory and define what it contains, the most significant 32 bits represent the expiration time(in seconds since UNIX epoch) and the lower 32 bits represent an arbitrary sequence number used to order statements with the same expiration time.channel_idandexpiryinteract.TODO