Add PVQ executor, primitives, and runtime API crates #10671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces three new crates: `pvq-executor`, `pvq-primitives`, and `pvq-runtime-api`. The `pvq-executor` crate provides functionality to execute PVQ programs on top of PolkaVM, including context management and error handling. The `pvq-primitives` crate defines shared types for PVQ execution, while the `pvq-runtime-api` crate exposes a runtime API for executing PVQ programs and retrieving metadata. Additionally, updates to `Cargo.toml` and `Cargo.lock` reflect the inclusion of these new crates in the workspace. - Added `pvq-executor` crate with execution logic and context management. - Added `pvq-primitives` crate for shared types. - Added `pvq-runtime-api` crate for runtime API definitions. - Updated workspace configuration in `Cargo.toml` and dependencies in `Cargo.lock`.
This commit deletes the `pvq-executor` and `pvq-runtime-api` crates, along with their associated README files. The `pvq-executor` crate, which provided functionality for executing PVQ programs on PolkaVM, and the `pvq-runtime-api` crate, which defined the runtime API for PVQ, have been removed from the project. Additionally, the `pvq-primitives` crate remains intact, as it defines shared types for PVQ execution. - Deleted `pvq-executor` crate and its README. - Deleted `pvq-runtime-api` crate and its README. - Retained `pvq-primitives` crate for shared types.
Contributor
|
Command "fmt" has failed ❌! See logs here |
paritytech-cmd-bot-polkadot-sdk
bot
added
the
T1-FRAME
Contributor
Author
|
/cmd fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR 1 of a 6-PR series to upstream the PVQ system. See tracking issue: #8251.
This PR introduces the foundation layer for PVQ (PolkaVM Query).
What's included
This PR adds three new foundational crates:
pvq-primitives(~50 lines): Core types includingPvqResult,PvqResponse, andPvqErrorwith bothstdandno_stdsupportpvq-runtime-api(~35 lines): Substrate runtime API definition withPvqApitrait providingexecute_queryandmetadatamethodspvq-executor(~400-500 lines): PolkaVM execution wrapper includingPvqExecutor,PvqExecutorContexttrait for registering host functions, program execution with gas limits, and error handlingIntegration
For Runtime Developers:
These crates provide the foundation infrastructure but are not yet ready for production use. No action is required from downstream teams at this time.
The complete PVQ system will be available after the all PRs are merged.
Once the full system is available, runtime developers can:
pvq-executorand extensions to their runtime dependenciesPvqApiruntime APIFor Node Operators & Client Developers:
No changes required. This is purely additive runtime infrastructure.
Review Notes
Architecture Overview
See tracking issue: #8251
Implementation Details
1. pvq-primitives
no_stdcompatible with optionalstdfeaturePvqResultencapsulates success/failure with structured errors2. pvq-runtime-api
sp_api::decl_runtime_apis!macroexecute_query: Takes program bytes, arguments, and gas limitmetadata: Returns available extensions and their capabilities3. pvq-executor
polkavmfor program executionPvqExecutorContexttrait allows runtimes to inject host functionsTesting
Future PRs
This foundation enables: