Skip to content

refund deposit_eth_extrinsic_revert_event on the base_weight #10693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgherveou wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refund deposit_eth_extrinsic_revert_event on the base_weight #10693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc1d981
refund deposit_eth_extrinsic_revert_event on the base_weight
pgherveou Dec 18, 2025
8fa54a8
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions prdoc/pr_10693.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
title: refund deposit_eth_extrinsic_revert_event on the base_weight
doc:
- audience: Runtime Dev
description: |-
When an eth transaction succeed we refund the pre-charged revert_event.
The refund should be done on the base weight and not the weight_consumed, as the latest could be lower than the cost of the revert_event
crates:
- name: pallet-revive
bump: patch
6 changes: 2 additions & 4 deletions substrate/frame/revive/src/evm/block_storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl EthereumCallResult {
pub(crate) fn new<T: Config>(
signer: AccountIdOf<T>,
mut output: ContractResult<ExecReturnValue, BalanceOf<T>>,
base_call_weight: Weight,
mut base_call_weight: Weight,
encoded_len: u32,
info: &DispatchInfo,
effective_gas_price: U256,
Expand All @@ -85,9 +85,7 @@ impl EthereumCallResult {

// Refund pre-charged revert event weight if the call succeeds.
if output.result.is_ok() {
output
.weight_consumed
.saturating_reduce(T::WeightInfo::deposit_eth_extrinsic_revert_event())
base_call_weight.saturating_reduce(T::WeightInfo::deposit_eth_extrinsic_revert_event())
}

let result = dispatch_result(output.result, output.weight_consumed, base_call_weight);
Expand Down
Loading