Fix benchmarking for pallet-assets::set_reserves() #10711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
added
T2-pallets
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
Contributor
Author
|
/cmd bench --runtime asset-hub-westend --pallet pallet-assets |
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet-assets" has started 🚀 See logs here |
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet-assets" has failed ❌! See logs here |
Contributor
Author
|
/cmd bench --runtime asset-hub-westend --pallet pallet_assets |
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet_assets" has started 🚀 See logs here |
…t-hub-westend --pallet pallet_assets'
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet_assets" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
shawntabrizi
approved these changes
Dec 27, 2025
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
code changes look good to me, seems the weight files are not updated yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrize pallet-assets::set_reserves() weight based on number of reserves provided instead of always assuming worst-case.