Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot Primitives v8 #5525

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Polkadot Primitives v8 #5525

merged 5 commits into from
Aug 30, 2024

Conversation

sandreim
Copy link
Contributor

As Runtime release 1.3.0 includes all of the remaining staging primitives and APIs we can now release primitives version 8.
No other changes other than renaming/moving done here.

Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim added the R0-silent Changes should not be mentioned in any release notes label Aug 29, 2024
polkadot/primitives/src/lib.rs Show resolved Hide resolved
Signed-off-by: Andrei Sandu <[email protected]>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7187462

Signed-off-by: Andrei Sandu <[email protected]>
Copy link
Contributor

@alexggh alexggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but this technically changes some public import paths in polkadot-primitives and polkadot-subsystem-util, so I think it can't be R0-silent and you need a PrDoc where you mark those crates as a major bump.

@sandreim sandreim added this pull request to the merge queue Aug 30, 2024
@sandreim
Copy link
Contributor Author

Approved, but this technically changes some public import paths in polkadot-primitives and polkadot-subsystem-util, so I think it can't be R0-silent and you need a PrDoc where you mark those crates as a major bump.

Shouldn't break anyone at code level, this stuff was already released.

Merged via the queue into master with commit 09035a7 Aug 30, 2024
186 of 189 checks passed
@sandreim sandreim deleted the sandreim/v8_primitives branch August 30, 2024 11:13
mordamax pushed a commit that referenced this pull request Aug 30, 2024
As Runtime release 1.3.0 includes all of the remaining staging
primitives and APIs we can now release primitives version 8.
No other changes other than renaming/moving done here.

---------

Signed-off-by: Andrei Sandu <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2024
A change that I missed to add in
#5525 .

---------

Signed-off-by: Andrei Sandu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants