Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch node side to v2 candidate receipts #5679

Merged
merged 145 commits into from
Oct 25, 2024
Merged

Switch node side to v2 candidate receipts #5679

merged 145 commits into from
Oct 25, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Sep 11, 2024 •
edited
Loading

on top of #5423

This PR implements the plumbing work required for #5047 . I also added additional helper methods gated by feature "test" in primitives.

TODO:

  • PRDoc

@sandreim
WIP primitives
793142e 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
WIP
3a29fdf 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Working version.
4a53577 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Better version
8285ae7 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Add missing primitives and fix things
2831c5e 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Implement v2 receipts in polkadot-runtime-parachains
c767d60 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
add missing stuff
96999e3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Switch parachains runtime to use new primitives
c5f2dc3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
use vstaging primitives
dbb0160 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
update rococo and westend
5efab68 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
client keeps using the old primitives
c2232e4 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
no unsafe pls
87b079f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
move async backing primtiives to own file
00e8c13 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix
cd4d02f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix test build
5509e33 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix test-runtime
f8b86d2 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
self review feedback
fe2fbfb 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
review feedback
975e13b 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
feedback
1c7ac55 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
feedback
653873b 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
clippy
dc98149 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
chores
0a6bce3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Filter v2 candidate descriptors
5e4dac2 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix
f12ca7a 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix prospective parachains tests
13734de 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix fix
effb1cc 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fmt
3f75cba 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix comment
75a47bb 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
another one
12ed853 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix build
f2c0882 
Signed-off-by: Andrei Sandu <[email protected]>
@alindima alindima mentioned this pull request Oct 2, 2024
Merged
Base automatically changed from sandreim/runtime_v2_descriptor_support to master October 7, 2024 07:22
@alindima alindima mentioned this pull request Oct 10, 2024
Merged
2 tasks
@sandreim
Copy link
Contributor Author

/cmd prdoc --audience node_dev,runtime_dev --bump major

@sandreim
remove bogus code
555c91b 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
90932b3 
…reim/node_v2_descriptors

Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Copy link
Contributor Author

/cmd prdoc --audience node_dev,runtime_dev --bump major

@sandreim
fix build
4b2c06f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fmt and feedback
320318a 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
more fixes
dfde71f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
delete PRDoc
cb93bb6 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Copy link
Contributor Author

/cmd prdoc --audience node_dev,runtime_dev --bump major

@sandreim
Copy link
Contributor Author

/cmd prdoc --audience node_dev runtime_dev --bump major

actions-user and others added 4 commits October 21, 2024 12:30
@actions-user
Update from sandreim running command 'prdoc --audience node_dev runti…
a402509 
…me_dev --bump major'
@sandreim
adjust generated PRDoc
6371454 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix build again
9c5097d 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix test
b2818f3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix example
f647249 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fmt
82da09a 
Signed-off-by: Andrei Sandu <[email protected]>
tdimitrov
tdimitrov approved these changes Oct 25, 2024
View reviewed changes
polkadot/node/network/statement-distribution/Cargo.toml Show resolved Hide resolved
polkadot/node/network/collator-protocol/src/validator_side/collation.rs
@@ -71,18 +71,15 @@ pub struct FetchedCollation {
pub para_id: ParaId,
/// Candidate hash.
pub candidate_hash: CandidateHash,
/// Id of the collator the collation was fetched from.
pub collator_id: CollatorId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why collator_id is dropped from CandidateDescriptorV2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not useful and getting rid of it made space for core_index and session_index

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at RFC103 for more details

tdimitrov
tdimitrov approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@tdimitrov tdimitrov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but please have a look at this comment.

@sandreim sandreim added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit 4c618a8 Oct 25, 2024
201 of 202 checks passed
@sandreim sandreim deleted the sandreim/node_v2_descriptors branch October 25, 2024 16:12
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 29, 2024
@sandreim @actions-user @mordamax
Switch node side to v2 candidate receipts (paritytech#5679)
239048d 
on top of paritytech#5423

This PR implements the plumbing work required for
paritytech#5047 . I also added
additional helper methods gated by feature "test" in primitives.

TODO:
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 29, 2024
@sandreim @actions-user @mordamax
Switch node side to v2 candidate receipts (paritytech#5679)
3d11c7f 
on top of paritytech#5423

This PR implements the plumbing work required for
paritytech#5047 . I also added
additional helper methods gated by feature "test" in primitives.

TODO:
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
@sandreim @actions-user
candidate-validation: RFC103 implementation (#5847)
2700dbf 
Part of #5047
On top of #5679

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2024
@sandreim @actions-user
statement-distribution: RFC103 implementation (#5883)
38cd03c 
Part of #5047
On top of #5679

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdimitrov tdimitrov tdimitrov approved these changes

@alindima alindima alindima approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandreim @tdimitrov @alindima @actions-user