Snowbridge Audit Issue 9 - Unused code should be removed #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
approved these changes
Oct 19, 2024
bkchr
added
R0-silent
bkchr
reviewed
Oct 20, 2024
| @@ -131,8 +131,6 @@ pub enum ConvertMessageError { | |||
| UnsupportedVersion, | |||
| InvalidDestination, | |||
| InvalidToken, | |||
| /// The fee asset is not supported for conversion. | |||
There was a problem hiding this comment.
No idea where this is used. However, this changes the encoding. Are you aware of this?
There was a problem hiding this comment.
@bkchr it is not used anywhere but you make a good point. I don't think removing this adds any benefit really. I could do:
pub enum ConvertMessageError {
/// The message version is not supported for conversion.
UnsupportedVersion = 0,
InvalidDestination = 1,
InvalidToken = 2,
/// Keeping the same index as before.
CannotReanchor = 4,
}
It's ugly, I'd rather just leave it in. @alistair-singh @yrong @vgeddes I'm going to close this PR unless you have reservations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A minor change required by Oak Security audit to remove unused code.
Requires labels R0-silent and T15-bridges.