remove pallet::getter from pallet-staking #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadanda
reviewed
Oct 24, 2024
| @@ -575,7 +575,7 @@ impl<T: Config> Pallet<T> { | |||
|
|
|||
| let era_duration = (now_as_millis_u64.defensive_saturating_sub(active_era_start)) | |||
| .saturated_into::<u64>(); | |||
| let staked = Self::eras_total_stake(&active_era.index); | |||
| let staked = Self::eras_total_stake(active_era.index); | |||
There was a problem hiding this comment.
Suggested change
| let staked = Self::eras_total_stake(active_era.index); | |
| let staked = ErasTotalStake::<T>::get(&active_era.index); |
Part of the aim here is to replace any usage of Self::storage() with Storage::<T>::get() in the sdk codebase
There was a problem hiding this comment.
Now it's done. I replaced these usages everywhere I was able to spot them.
seadanda
reviewed
Nov 7, 2024
seadanda
reviewed
Nov 8, 2024
seadanda
approved these changes
Nov 8, 2024
gui1117
reviewed
Nov 13, 2024
Co-authored-by: Guillaume Thiolliere <[email protected]>
gui1117
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3326
Removes all pallet::getter occurrences from pallet-staking and replaces them with explicit implementations.
Adds tests to verify that retrieval of affected entities works as expected so via storage::getter.
Review Notes
deriveattribute are used in tests (either directly or indirectly).#[pallet::call]and that requires#[pallet::call_index(0)]annotation on each function in that block. So I thought it's better to separate them.