Fix metrics not shutting down if there are open connections #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we want to prevent this again from happening? By introducing a test? :D |
bkchr
approved these changes
Oct 24, 2024
|
@tmpolaczyk also please provide some prdoc. |
lexnv
approved these changes
Oct 25, 2024
|
@bkchr not sure if this is easy to test. I have a zombienet test in our project that will fail if this breaks, but it takes 5 minutes to run. For a unit test we would need to:
|
skunert
approved these changes
Oct 25, 2024
pepoviola
reviewed
Oct 25, 2024
prdoc/pr_6220.prdoc
Outdated
| @@ -0,0 +1,10 @@ | |||
| title: Improve `CheckMetadataHash` transaction extension weight and logic | |||
There was a problem hiding this comment.
title needs to be updated, to reference the actual fix.
|
@bkchr is there anything else to do before merging this PR? |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Fix prometheus metrics not shutting down if there are open connections. I fixed the same issue in the past but it broke again after a dependecy upgrade. See also: #1637
|
No! Sorry for forgetting! 😅 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
paritytech:master
with commit Nov 19, 2024
0449b21
190 of 194 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix prometheus metrics not shutting down if there are open connections. I fixed the same issue in the past but it broke again after a dependecy upgrade.
See also:
#1637