Increase default trie cache size to 1GiB #6546
Open
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default trie cache size before was set to `64MiB`, which is quite low to achieve real speed ups. `1GiB` should be a reasonable number as the requirements for validators/collators/full nodes are much higher when it comes to minimum memory requirements. Also the cache will not use `1GiB` from the start and fills over time. The setting can be changed by setting `--trie-cache-size BYTE_SIZE`.
|
/cmd prdoc --bump patch --audience node-operator |
iulianbarbu
approved these changes
Nov 19, 2024
|
Command "prdoc --bump patch --audience node-operator" has failed ❌! See logs here |
|
/cmd prdoc --bump patch --audience node_operator |
| \ low to achieve real speed ups. `1GiB` should be a reasonable number as the requirements\ | ||
| \ for validators/collators/full nodes are much higher when it comes to minimum\ | ||
| \ memory requirements. Also the cache will not use `1GiB` from the start and fills\ | ||
| \ over time. The setting can be changed by setting `--trie-cache-size BYTE_SIZE`.\r\ |
There was a problem hiding this comment.
nit: removal of state_cache_size could be mentioned.
michalkucharczyk
approved these changes
Nov 19, 2024
sandreim
approved these changes
Nov 19, 2024
| \n" | ||
| crates: | ||
| - name: sc-cli | ||
| bump: patch |
There was a problem hiding this comment.
Doesn't removal of state_cache_size require a major here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default trie cache size before was set to
64MiB, which is quite low to achieve real speed ups.1GiBshould be a reasonable number as the requirements for validators/collators/full nodes are much higher when it comes to minimum memory requirements. Also the cache will not use1GiBfrom the start and fills over time. The setting can be changed by setting--trie-cache-size BYTE_SIZE.