Skip to content

Adds --exclude-extrinsics support for frame-omni-bencher #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bkontur wants to merge 4 commits into from
Closed

Adds --exclude-extrinsics support for frame-omni-bencher #8257

bkontur wants to merge 4 commits into from

Conversation

@bkontur
Copy link
Contributor

@bkontur bkontur commented Apr 16, 2025

No description provided.

@bkontur bkontur requested a review from a team as a code owner April 16, 2025 11:59
@bkontur bkontur added T12-benchmarks This PR/Issue is related to benchmarking and weights. R0-no-crate-publish-required The change does not require any crates to be re-published. labels Apr 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@bkontur
Copy link
Contributor Author

bkontur commented Apr 16, 2025

/cmd --help

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@bkontur
Copy link
Contributor Author

bkontur commented Apr 16, 2025

/cmd prdoc --audience runtime_dev --bump patch

ggwpez
ggwpez reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code in hope that we just use it in CI - if we release it then I would make it a bit more orderly.

@EgorPopelyaev
[CI/CD] Add a pipeline to build binaries in different profiles (#7496)
bd44212 
Recently there were some requests to build and deploy a binary, for
example `polkadot`, in the `release` or `production` profile to do some
testing.
So far we had only a
[release](https://github.com/paritytech/polkadot-sdk/blob/master/.github/workflows/release-20_build-rc.yml)
pipeline that could do it in the GitHub but to use it, there was a lot
of extra overhead needed.
This pipeline should simplify this case and give a possibility to build
a binary in desired profile from any branch for the testing purposes.
Something similar to what we have for runtimes in the [srtool
repo](https://github.com/paritytech/srtool/actions/workflows/manual.yml)
It won't be used in any release activities though.

CC: @BulatSaif
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners April 16, 2025 13:26
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 16, 2025 13:27
@EgorPopelyaev
Copy link
Contributor

EgorPopelyaev commented Apr 16, 2025

Binary was build directly from the oty-stable2412-benchmarker-pallets branch, so I'll close it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez left review comments

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkontur @EgorPopelyaev @ggwpez