This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[WIP]: Construct Runtime v2 #14788
Draft
gupnik
wants to merge
22
commits into
master
Choose a base branch
from
gupnik/cr-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP]: Construct Runtime v2 #14788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gupnik
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
B1-note_worthy
Changes should be noted in the release notes
T1-runtime
This PR/Issue is related to the topic “runtime”.
labels
Aug 18, 2023
The CI pipeline was cancelled due to failure one of the required jobs. |
The index should be required and not be optional. |
@bkchr By default, the index is derived from the order in which the pallets appear in the struct. If this attribute is specified, this default index is overridden. This is consistent with the current behaviour of |
The indexes should be obligatory. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A3-in_progress
Pull request is in progress. No review needed at this stage.
B1-note_worthy
Changes should be noted in the release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T1-runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/polkadot-sdk#232
This PR introduces outer-macro approach for
construct_runtime
as discussed in the linked issue. It looks like the following:Features
#[frame::runtime]
attached to a struct defines the main runtime#[frame::pallets]
attached to a struct defines the pallets in the runtime#[frame::derive]
attached to this struct defines the types generated byconstruct_runtime
#[frame::pallet_index]
can be optionally attached to a pallet to override its index#[frame::disable_call]
can be optionally attached to a pallet to disable its callsTemplateModule: pallet_template<Instance>
Todo
#[frame::disable_unsigned]
to disable unsigned callsExtension