This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Restructure frame_support::dispatch macro related exports#14817
Open
juangirini wants to merge 59 commits intomasterfrom
Open
Restructure frame_support::dispatch macro related exports#14817juangirini wants to merge 59 commits intomasterfrom
frame_support::dispatch macro related exports#14817juangirini wants to merge 59 commits intomasterfrom
Conversation
… jg/restructure-dispatch-macro-related-exports
… jg/restructure-dispatch-macro-related-exports
This was referenced Aug 24, 2023
Base automatically changed from
jg/restructure-benchmarking-macro-related-exports
to
master
August 24, 2023 15:32
Contributor
Author
|
bot rebase |
|
Error: Command 'Command { std: cd "/storage/repositories/substrate" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
reviewed
Aug 24, 2023
Comment on lines
+34
to
+40
| /// Private exports that are being used by macros. | ||
| /// | ||
| /// The exports are not stable and should not be relied on. | ||
| #[doc(hidden)] | ||
| pub mod __private { | ||
| pub use sp_runtime::traits::Dispatchable; | ||
| } |
Member
There was a problem hiding this comment.
Not sure we need here an extra __private mod. Can we not just put this as well into lib.rs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for paritytech/polkadot-sdk#172
Cumulus companion: paritytech/cumulus#3058
Polkadot companion: paritytech/polkadot#7663