This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Changed LPFee to Permill type in Asset Conversion Pallet #14823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatricioNapoli
added
A0-please_review
PatricioNapoli
requested review from
gilescope,
jsidorenko,
joepetrowski and
a team
PatricioNapoli
added
the
D3-trivial 🧸
xlc
reviewed
Aug 24, 2023
frame/asset-conversion/src/lib.rs
Outdated
| @@ -1169,10 +1171,13 @@ pub mod pallet { | |||
| .checked_mul(&1000u32.into()) | |||
| .ok_or(Error::<T>::Overflow)?; | |||
|
|
|||
| let fee_mult = | |||
| T::HigherPrecisionBalance::from(1_000_000u32 - T::LPFee::get().deconstruct()); | |||
There was a problem hiding this comment.
this is just confusing and not a good usage of Permill type
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/polkadot-sdk#88
Changed Liquidity Pool fee in Asset Conversion pallet from a Const to a Permill type.